Enhance LLaVA dataset processing with optional text preprocessing #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear XTuner Contributors,
Thank you for providing the open-source code for MLLM. I noticed that the process_hf_dataset function in the LLaVADataset takes several minutes to preprocess text data each time the program starts. In contrast, some other repositories (e.g., Original LLaVA, LLaVA-Next) handle text data preprocessing during training.
To address this, I have proposed an enhancement to the LLaVA dataset processing by introducing optional text preprocessing. This modification eliminates the need to preprocess text data at runtime, improving efficiency.
I kindly request you review my code and consider merging my PR.
Best regards,
wanghao9610