Skip to content

Conversation

mohamedawnallah
Copy link
Member

@mohamedawnallah mohamedawnallah commented Aug 16, 2023

Description

This pull request addresses the fixes required for alarm correlation and aggregation discussions 17, 18, and adding the data source and alarm types header in the alarm filters area so that it could differentiate between the data source and alarm type

How Has This Been Tested?

All tests passed: npm test

Screenshots (if appropriate):

Screenshot 2023-08-16 at 3 23 25 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mohamedawnallah mohamedawnallah self-assigned this Aug 16, 2023
@mohamedawnallah mohamedawnallah added the enhancement New feature or request label Aug 16, 2023
…ation and Aggregation Project in addition to adding the data source and alarm types header in alarm filters area
@mohamedawnallah mohamedawnallah force-pushed the feature/address-discussions-#17-#18 branch from ff13cd1 to c2c88fd Compare August 16, 2023 12:27
@romain-fontugne romain-fontugne merged commit c2c88fd into InternetHealthReport:alarm-corr-aggr Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants