Introduce Template Haskell companion library. #15
Conversation
jonathanknowles
force-pushed
the
jonathanknowles/bech32-th
branch
4 times, most recently
from
f1b4ca0 to
27b4115
Compare
jonathanknowles
force-pushed
the
jonathanknowles/bech32-th
branch
2 times, most recently
from
97caeca to
5bd598a
Compare
jonathanknowles
force-pushed
the
jonathanknowles/bech32-th
branch
from
5bd598a to
574cf25
Compare
jonathanknowles
changed the title
.travis.yml
Outdated
| - cabal-3.0 haddock | ||
| - cabal-3.0 sdist | ||
| - pushd bech32 && cabal-3.0 check && popd | ||
| - pushd bech32-th && cabal-3.0 check && popd |
There was a problem hiding this comment.
Unfortunately we can't run a cabal check all here, as this is not yet supported. (See haskell/cabal#6282)
There was a problem hiding this comment.
check may not work, but what about test ?
eg https://github.com/HuwCampbell/grenade/blob/master/.travis.yml#L27-L29
There was a problem hiding this comment.
checkmay not work, but what abouttest?
The test command still works. See a couple of lines down:
- cabal-3.0 test all --test-show-details=streaming
There was a problem hiding this comment.
Ah, that's right, check just checks that the packaging info is right. Never mind me. Yes I think your solution works, but so does:
(cd bech32 && cabal-3.0 check)
(cd bech32-th && cabal-3.0 check)
and has better behavior in the failure case.
There was a problem hiding this comment.
(cd bech32 && cabal-3.0 check)
(cd bech32-th && cabal-3.0 check)
That's a great suggestion. I'll make the change: 👍
bech32-th/ChangeLog.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| # ChangeLog for `bech32-th` | |||
|
|
|||
| ## 1.0.2 -- 2020-02-18 | |||
There was a problem hiding this comment.
We start immediately with 1.0.2 so that bech32 and bech32-th can be kept in lockstep with one another.
This package adds Template-Haskell-specific extensions to the `bech32` library. In particular, it includes quasi-quoters capable of checking Bech32 string literals at compile-time.
Unfortunately, there is no `cabal check all`. See: haskell/cabal#6282 So we have to manually change directories before we can issue the `cabal check` command.
In response to review feedback: #15 (comment)
jonathanknowles
force-pushed
the
jonathanknowles/bech32-th
branch
from
574cf25 to
f156577
Compare
| forM_ invalidHumanReadableParts $ \(hrp, expectedError) -> | ||
| it (show hrp) $ | ||
| mkHumanReadablePartExp hrp | ||
| `shouldThrow` (== expectedError) |
This PR:
bech32-th, with an accompanying test suite.cabal check.1.0.2, in preparation for a new release.