Skip to content

SDELEG STS _verify_ is not implemented #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
uroboros opened this issue Jul 29, 2019 · 0 comments · Fixed by #863
Closed

SDELEG STS _verify_ is not implemented #675

uroboros opened this issue Jul 29, 2019 · 0 comments · Fixed by #863
Assignees
@dnadales
Labels
byron 🍰 good first issue Good for newcomers ⚙️ executable-model

Comments

@uroboros
Copy link
Contributor

Currently

verify :: DCert -> Bool
verify = const True

We can use Ledger.Core.verify to implement the above (see how this is done in the Utxo update)

verify :: Eq a => VKey -> a -> Sig a -> Bool
verify (VKey vk) vd (Sig sd sk) = vk == sk && vd == sd
@uroboros uroboros mentioned this issue Jul 29, 2019
Closed
5 tasks
@uroboros uroboros mentioned this issue Aug 8, 2019
Closed
@uroboros uroboros added the 🍰 good first issue Good for newcomers label Aug 12, 2019
@dnadales dnadales self-assigned this Sep 17, 2019
dnadales added a commit that referenced this issue Sep 17, 2019
@dnadales
Check the signature of the delegation certificate in the SDELEG rule.
0056e16 
Closes #675.
@dnadales dnadales mentioned this issue Sep 17, 2019
Merged
dnadales added a commit that referenced this issue Sep 18, 2019
@dnadales
Check the signature of the delegation certificate in the SDELEG rul…
6b9e237 
…e. (#863)

Closes #675.
kevinhammond pushed a commit that referenced this issue Oct 28, 2019
@dnadales
Check the signature of the delegation certificate in the SDELEG rul…
5d37747 
…e. (#863)

Closes #675.
nc6 pushed a commit that referenced this issue May 19, 2020
@iohk-bors @dcoutts
Merge #675
7d350f2 
675: Remove unused crypto r=johnalotoski a=dcoutts

The summary is that `SafeSigner` can be simplified because we do not use its special feature at all. This then unlocks a cascade of other now-unused code that we can remove, including eliminating `EncryptedSigningKey` and dropping the `scrypt` dependency.

See the individual patches for more detailed explanations. It's structured as a series of small changes so should hopefully be easy to follow.

This builds on #674 so look at the first 4 patches in the context of that PR and ignore them for this one.

Fixes #664 
Fixed #665

Co-authored-by: Duncan Coutts <[email protected]>
@mrBliss mrBliss mentioned this issue Jan 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnadales dnadales

Labels
byron 🍰 good first issue Good for newcomers ⚙️ executable-model
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check the signature of the delegation certificate in the SDELEG rule. IntersectMBO/cardano-ledger
2 participants
@uroboros @dnadales