Skip to content

SRI-61 Add x86_64-w64-mingw32 tests checks to required job #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

SRI-61 Add x86_64-w64-mingw32 tests checks to required job #1835

merged 1 commit into from
Mar 23, 2020

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Mar 23, 2020

No description provided.

@jbgi jbgi force-pushed the require-windows-tests branch from 12d0f2a to e138759 Compare March 23, 2020 10:46
mrBliss
mrBliss reviewed Mar 23, 2020
View reviewed changes
@jbgi jbgi force-pushed the require-windows-tests branch from e138759 to 01b442f Compare March 23, 2020 11:30
@jbgi jbgi changed the title Add x86_64-w64-mingw32 tests checks to required job SRI-61 Add x86_64-w64-mingw32 tests checks to required job Mar 23, 2020
@jbgi jbgi changed the base branch from master to bors/staging March 23, 2020 11:58
@jbgi jbgi changed the base branch from bors/staging to master March 23, 2020 11:58
@jbgi jbgi requested a review from mrBliss March 23, 2020 11:59
@mrBliss
Copy link
Contributor

mrBliss commented Mar 23, 2020

Can we try running test-storage on mingw32 with --quickcheck-tests=10000 to be sure that the tests "always" pass? In the past, they sometimes failed in unrelated PRs (#885). We don't want that again.

@jbgi jbgi requested a review from disassembler March 23, 2020 14:37
@mrBliss
Copy link
Contributor

mrBliss commented Mar 23, 2020

(If it wasn't clear from my last message, running 10k tests is just a temporary thing. When we see that they all pass, we can revert it back to the default before we merge this PR.)

@mrBliss
Copy link
Contributor

mrBliss commented Mar 23, 2020 •
edited
Loading

It looks like all 10k tests pass on Hydra, so you can drop the last commit and merge it 👍

@jbgi jbgi force-pushed the require-windows-tests branch from 949422f to 01b442f Compare March 23, 2020 15:01
@jbgi
Copy link
Contributor Author

jbgi commented Mar 23, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 23, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 13bff16 into master Mar 23, 2020
@iohk-bors iohk-bors bot deleted the require-windows-tests branch March 23, 2020 15:38
@dcoutts dcoutts mentioned this pull request Mar 24, 2020
Closed
This was referenced Mar 24, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrBliss mrBliss mrBliss approved these changes

@disassembler disassembler disassembler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbgi @mrBliss @disassembler