[MOB-5406] create notification channel for each sound #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evangreer91
changed the base branch from
master
to
evan/MOB-5365-update-notification-channel-builder-to-set-sound
Codecov ReportBase: 62.12% // Head: 62.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## evan/MOB-5365-update-notification-channel-builder-to-set-sound #488 +/- ##
==================================================================================================
+ Coverage 62.12% 62.49% +0.36%
==================================================================================================
Files 67 67
Lines 3929 3922 -7
Branches 452 450 -2
==================================================================================================
+ Hits 2441 2451 +10
+ Misses 1247 1232 -15
+ Partials 241 239 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Ayyanchira
reviewed
Jan 24, 2023
iterableapi/src/main/java/com/iterable/iterableapi/IterableNotificationHelper.java
Show resolved
Hide resolved
Ayyanchira
reviewed
Jan 24, 2023
iterableapi/src/main/java/com/iterable/iterableapi/IterableNotificationHelper.java
Show resolved
Hide resolved
Ayyanchira
approved these changes
Jan 30, 2023
Base automatically changed from
evan/MOB-5365-update-notification-channel-builder-to-set-sound
to
custom-sound
January 30, 2023 19:24
evangreer91
deleted the
evan/MOB-5406-create-notification-channel-for-each-sound
branch
Ayyanchira
pushed a commit
that referenced
this pull request
Feb 13, 2023
…on-channel-for-each-sound [MOB-5406] create notification channel for each sound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
This pull request provides unique notification channels for each sound sent from the Iterable UI. There are checks to provide the default sound for edge cases provided by the custom sound box on the UI. The UI may be changed in the future to not except these edge cases.