[MOB-5828] Firetv updateuser fix #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtruong
reviewed
Mar 16, 2023
| dataFields.put(IterableConstants.DEVICE_APP_VERSION, IterableUtil.getAppVersion(context)); | ||
| dataFields.put(IterableConstants.DEVICE_APP_BUILD, IterableUtil.getAppVersionCode(context)); | ||
| dataFields.put(IterableConstants.DEVICE_ITERABLE_SDK_VERSION, IterableConstants.ITBL_KEY_SDK_VERSION_NUMBER); | ||
| dataFields.put(IterableConstants.DEVICE_NOTIFICATIONS_ENABLED, !isFireTV(context.getPackageManager()) && NotificationManagerCompat.from(context).areNotificationsEnabled()); |
There was a problem hiding this comment.
This field can be removed from populateDeviceDetails and put only in the registerDeviceToken method as it only relates to devices with push enabled.
Ayyanchira
reviewed
Mar 21, 2023
iterableapi/src/main/java/com/iterable/iterableapi/util/DeviceInfoUtils.java
Show resolved
Hide resolved
Ayyanchira
reviewed
Mar 21, 2023
iterableapi/src/main/java/com/iterable/iterableapi/util/DeviceInfoUtils.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/util/DeviceInfoUtils.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/util/DeviceInfoUtils.java
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
==========================================
- Coverage 62.29% 61.99% -0.30%
==========================================
Files 67 68 +1
Lines 3970 3984 +14
Branches 462 465 +3
==========================================
- Hits 2473 2470 -3
- Misses 1253 1265 +12
- Partials 244 249 +5
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.