-
Notifications
You must be signed in to change notification settings - Fork 4
add option showHeader #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
false disables the generation of the table header in the HTML renderers e.g. $renderer = new SideBySide(['showHeader' => false]);
@vendeeglobe Thanks for your effort.
@JBlond Did you read my email? |
I don't like this change. In the discussion You (@vendeeglobe) mentioned jfcherng/php-diff@5f0dd2d if (!$this->options['showHeader']) {
return '';
} This patch on the other hand only tries to change some of the code. It is a cleaner option to extend the desired class and override a single method. See https://github.com/JBlond/php-diff/wiki/3.-Custom-Renderer |
@@ -72,15 +74,22 @@ public function render() | |||
*/ | |||
public function generateDiffHeader(): string | |||
{ | |||
return <<<HTML | |||
$html = <<<HTML |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a clean solution.
JBlond wrote:
I vote for what I offered at issue #53 (comment) IMHO overriding is the cleanest and most versatile way to generate custom output, based on a current renderer. However, I do appreciate his usage of our package and the feedback he gives us. |
@vendeeglobe is that an option for you that DigiLive helps you to make that changes in your repo? |
There wasn't any feedback within two weeks. Please add another commend, if you want to contiune. |
HTML Inline Renderer -> Options
https://github.com/JBlond/php-diff/wiki/2.-Parameters-and-Options