Skip to content

exclude not needed files for zip / composer export #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2020
Merged

exclude not needed files for zip / composer export #87

merged 2 commits into from
Dec 16, 2020

Conversation

JBlond
Copy link
Owner

@JBlond JBlond commented Dec 15, 2020

No description provided.

@JBlond JBlond requested a review from DigiLive December 15, 2020 14:20
DigiLive
DigiLive reviewed Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@DigiLive DigiLive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • README.md is included, but it contains relative references to the assets folder which you want to exclude?
  • I'm not sure if the excluded folders should or shouldn't contain a trailing slash.

DigiLive
DigiLive approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@DigiLive DigiLive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did your try if paths need a trailing / or not?

@JBlond JBlond merged commit 3655d22 into master Dec 16, 2020
@JBlond JBlond deleted the export-settings branch December 16, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DigiLive DigiLive DigiLive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JBlond @DigiLive