-
Notifications
You must be signed in to change notification settings - Fork 9
Commit CRTMv3 configuration (backward compatible with 2.4) #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…static libcrtm.a or libcrtm.so
… force number of streams to maximum.
…with only netCDF coefficients.
…_library_path load, throw breadcrumbs to user to set dyld_library_path, because you that is a no-no to do automatically.
…only build option vs distutil) bug that ignores any directive flags for #ifdef. Force the issue by putting it into f90flags.
…default in miniconda, and modernize the install process to use pip install ., instead of python setup.py install."
for root,dirs,filez in os.walk(searchPath): | ||
for name in filez: | ||
srcPath = os.path.join(root,name) | ||
if(not ('ODAS' in srcPath or 'Big_Endian' in srcPath)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karpob as an FYI: future CRTMv3 after v3.2.x will be netCDF only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah my thought is when it's netcdf only to move all of that out of setup.py into something like cartopy does for higher resolution maps where it downloads on request when it doesn't find anything. Also, at some point figure out how to remove setup.py completely.
Hello Bryan, This is cool! I like make_it_so.sh very much. I used There are a few hiccups though that I had to manually install some libraries, which seems to be caused by the failure of activating a virtual environment with the following command.
I'm able to install netcdf-fortran with conda forge though:
All other libs work with conda create. |
@chengdang Good catch! I forgot to move my .condarc when I was testing this (I usually just put conda-forge by default by habit to avoid licensing issues.) I added a line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! Everything works as expected now. I am able to create pycrtm, and run the example. Thank you!
I added back the |
Also added fix per #20 where LD_LIBRARY_PATH wasn't set automatically as designed, when using shared libraries. |
Description
Adds CRTMv3 capability while maintaining 2.4 compatibility. Also modernizes setup removing deprecated (or soon to be deprecated) "python setup.py install" method in favor of "pip install . " method. Adds helper scripts to install CRTMv3 + pyCRTM, along with dependencies using miniconda.
Also resolves #17 fixing issues related to setuptools version changes, along with f2py issues. This is done by replacing f2py executable which has bug related to passing preprocessor directives with "python -m numpy.f2py" which passes preprocessor directives correctly.
Issue(s) addressed
Resolves #17
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
None
Checklist