BACKLOG-22337: Implement new GraphQLDirectiveProvider for validation #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to somehow be able to refresh our jahia docker container to include the new graphql-java-servlet artifact. Not sure if there's an action we can trigger for that without doing a commit to jahia-private |
|
Modified graphql-java-servlet finally in docker builds and tests are passing. |
cedmail
previously approved these changes
Feb 9, 2024
cedmail
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/BACKLOG-22337
Description
graphql-java-servlet has been patched to include custom directive definitions when building/validating schema (PR here and here).
Implement this new provider in graphql-core and fix validation issues to make SDL extensions work again.
Also added cypress test to check for SDL extensions defined in core and graphql-extension-examples