feat: Add library installation before sketch builds in CI scripts #6
+169
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds library installation functionality to CI scripts before building Arduino sketches, introduces a new board configuration for the Twin AIoT Module, and fixes documentation formatting issues.
- Adds automated library installation from ci.json files before sketch compilation
- Introduces configuration for a new ESP32-S3 based board variant called "twinaiot"
- Corrects RST formatting issues in documentation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| variants/twinaiot/pins_arduino.h | Defines pin mappings and hardware constants for the new Twin AIoT Module board |
| docs/en/guides/core_compatibility.rst | Fixes RST formatting by replacing backticks with proper double backticks and correcting documentation URLs |
| boards.txt | Adds complete board configuration for the Twin AIoT Module with ESP32-S3 target and various menu options |
| .github/scripts/tests_build.sh | Integrates library installation call before individual sketch builds |
| .github/scripts/sketch_utils.sh | Implements comprehensive install_libs function with support for both named libraries and GitHub URLs |
| .github/scripts/on-push.sh | Adds library installation before sketch building in the push workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
variants/twinaiot/pins_arduino.h
Outdated
Comment on lines
21
to
22
| static const uint8_t SDA = 39; | ||
| static const uint8_t SCL = 40; |
There was a problem hiding this comment.
I2C pins SDA and SCL are assigned the same values as UART TX and RX pins (39 and 40). This creates a pin conflict where the same GPIO pins are defined for different protocols, which will cause hardware interface issues.
Suggested change
| static const uint8_t SDA = 39; | |
| static const uint8_t SCL = 40; | |
| static const uint8_t SDA = 41; | |
| static const uint8_t SCL = 42; |
Copilot uses AI. Check for mistakes.
Comment on lines
+668
to
+665
| needs_unsafe=true | ||
| break |
There was a problem hiding this comment.
The code only validates GitHub URLs but allows installation from any GitHub repository without verification. Consider adding validation to ensure URLs are from trusted sources or implement a whitelist mechanism.
Suggested change
| needs_unsafe=true | |
| break | |
| if is_trusted_github_url "$lib"; then | |
| needs_unsafe=true | |
| else | |
| echo "ERROR: Library $lib is not in the whitelist of trusted GitHub repositories. Refusing to install." | |
| exit 1 | |
| fi |
Copilot uses AI. Check for mistakes.
| if [ "$needs_unsafe" = true ]; then | ||
| [ "$verbose" = true ] && echo "Checking current unsafe install setting..." | ||
| # Get current setting | ||
| original_unsafe_setting=$("$ide_path/arduino-cli" config get library.enable_unsafe_install 2>/dev/null || echo "false") |
There was a problem hiding this comment.
The fallback value 'false' may not match the actual default setting of arduino-cli. If the config command fails, this could lead to incorrect restoration of the original setting.
Copilot uses AI. Check for mistakes.
Test Results 76 files 76 suites 13m 12s ⏱️ Results for commit eac284b. ♻️ This comment has been updated with latest results. |
👋 Hello JakubAndrysek, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
JakubAndrysek
force-pushed
the
ci/arduino-cli-lib-install
branch
from
0d377ea to
ec5a245
Compare
JakubAndrysek
force-pushed
the
ci/arduino-cli-lib-install
branch
2 times, most recently
from
5acea26 to
9261853
Compare
JakubAndrysek
force-pushed
the
ci/arduino-cli-lib-install
branch
from
9261853 to
03b5724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.