Skip to content

Test the list of flaky tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ PYTHON ?= python
DESTDIR ?=
SIGN ?=
PREFIX ?= /usr/local
FLAKY_TESTS ?= run
STAGINGSERVER ?= node-www

OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]')
Expand Down Expand Up @@ -140,8 +141,8 @@ test-all-valgrind: test-build
$(PYTHON) tools/test.py --mode=debug,release --valgrind

test-ci: | build-addons
$(PYTHON) tools/test.py -p tap --logfile test.tap --mode=release \
addons message parallel sequential
$(PYTHON) tools/test.py -p tap --logfile test.tap --mode=release --flaky-tests=$(FLAKY_TESTS) \
addons message internet parallel sequential

test-release: test-build
$(PYTHON) tools/test.py --mode=release
Expand Down
22 changes: 22 additions & 0 deletions test/internet/internet.status
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
prefix internet

# To mark a test as flaky, list the test name in the appropriate section
# below, without ".js", followed by ": PASS,FLAKY". Example:
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
test-dns : PASS,FLAKY

[$system==win32]

[$system==linux]
test-dgram-broadcast-multi-process : PASS,FLAKY
test-dgram-multicast-multi-process : PASS,FLAKY

[$system==macos]

[$system==solaris] # Also applies to SmartOS

[$system==freebsd]
test-dgram-broadcast-multi-process : PASS,FLAKY
test-dgram-multicast-multi-process : PASS,FLAKY
7 changes: 6 additions & 1 deletion test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,19 @@ prefix parallel
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms
test-timers-first-fire : PASS,FLAKY

[$system==win32]
test-tls-ticket-cluster : PASS,FLAKY

[$system==linux]
test-tick-processor : PASS,FLAKY
test-process-argv-0 : PASS,FLAKY

[$system==macos]

[$system==solaris] # Also applies to SmartOS
test-debug-signal-cluster : PASS,FLAKY

[$system==freebsd]

test-net-socket-local-address : PASS,FLAKY
3 changes: 2 additions & 1 deletion vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ if /i "%1"=="noetw" set noetw=1&goto arg-ok
if /i "%1"=="noperfctr" set noperfctr=1&goto arg-ok
if /i "%1"=="licensertf" set licensertf=1&goto arg-ok
if /i "%1"=="test" set test_args=%test_args% sequential parallel message -J&set jslint=1&goto arg-ok
if /i "%1"=="test-ci" set test_args=%test_args% -p tap --logfile test.tap message sequential parallel&goto arg-ok
if /i "%1"=="test-ci" set test_args=%test_args% -p tap --logfile test.tap message internet sequential parallel&goto arg-ok
if /i "%1"=="test-simple" set test_args=%test_args% sequential parallel -J&goto arg-ok
if /i "%1"=="test-message" set test_args=%test_args% message&goto arg-ok
if /i "%1"=="test-gc" set test_args=%test_args% gc&set buildnodeweak=1&goto arg-ok
Expand All @@ -70,6 +70,7 @@ if /i "%1"=="small-icu" set i18n_arg=%1&goto arg-ok
if /i "%1"=="full-icu" set i18n_arg=%1&goto arg-ok
if /i "%1"=="intl-none" set i18n_arg=%1&goto arg-ok
if /i "%1"=="download-all" set download_arg="--download=all"&goto arg-ok
if /i "%1"=="ignore-flaky" set test_args=%test_args% --flaky-tests=dontcare&goto arg-ok

echo Warning: ignoring invalid command line option `%1`.

Expand Down