Introduce common SelectionTests #1146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
reviewed
Feb 27, 2024
Comment on lines
65
to
75
| Key.AltLeft -> false | ||
| Key.MetaLeft -> false | ||
| Key.ShiftLeft -> false | ||
| Key.CtrlLeft -> false | ||
| Key.Delete -> false | ||
| Key.DirectionLeft -> false | ||
| Key.DirectionRight -> false | ||
| Key.DirectionDown -> false | ||
| Key.DirectionUp -> false | ||
| Key.Home -> false | ||
| Key.MoveEnd -> false |
There was a problem hiding this comment.
Make sense, pushed this change.
eymar
reviewed
Feb 28, 2024
| else -> DefaultKeyboardActions | ||
| } | ||
|
|
||
| internal class WasmSelectionTests : |
There was a problem hiding this comment.
Probably doesn't need to be internal. But I checked the tests run anyway - wasn't sure.
There was a problem hiding this comment.
@eymar
it's internal, because CommonSelectionTests is internal, so we can either:
- make CommonSelectionTests tests public as well
or - leave the way it is
both is fine with me, the "leave it as it is option" however is - I can not argue - more fragile - I can imagine that something will change in tooling, internal tests will be just ignored and we'll miss it.
eymar
approved these changes
Feb 28, 2024
Schahen
force-pushed
the
COMPOSE-823-selection-tests-pr
branch
from
7b5307e to
38f74b2
Compare
|
In the framework of this PR we've decided to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this is start for having more and more common tests for keyboard-related staff