Skip to content

Make react recipes compatible with try-purescript #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

milesfrain
Copy link
Collaborator

Fixes #196

I you open the dev console, you'll find this warning from react-dom.development.js

Warning: render(): Rendering components directly into document.body is discouraged, since its children are often manipulated by third-party scripts and browser extensions. This may lead to subtle reconciliation issues. Try rendering into a container element created for your app.

But this is the same as what Halogen does, so I don't think we need to be concerned.

@maddie927
Copy link
Contributor

maddie927 commented Aug 5, 2020

This version does not warn: react demo

@maddie927
Copy link
Contributor

Cleaned it up a little more here (should've cleaned up the other links too, sorry 😅 )

@milesfrain
Copy link
Collaborator Author

Wondering if it makes sense to add createRootElement to a library to keep these examples compact.

@JordanMartinez
Copy link
Owner

Thanks!

@JordanMartinez JordanMartinez merged commit dc4ad70 into JordanMartinez:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Broken React Examples in Try PureScript
3 participants