Skip to content

Bump easy-purescript-nix #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pete-murphy
Copy link
Collaborator

packages.dhall specifies PureScript 0.13.8, while the easy-purescript-nix commit hash points to 0.13.6, so trying to build the project in nix-shell fails.

Before

Screen Shot 2021-01-18 at 1 36 19 AM

After

Screen Shot 2021-01-18 at 1 37 39 AM

Copy link
Collaborator

@milesfrain milesfrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't jumped on the nix train yet, but I trust this is a change for the better.
Also, those are some nice looking shadowed screenshots. Was wondering if that was a new GH feature, but guessing you just grabbed a bit of desktop too.

@pete-murphy
Copy link
Collaborator Author

I haven't jumped on the nix train yet, but I trust this is a change for the better.

Yeah, I don't know, it seems like keeping the shell.nix up to date might be a bit of a burden if the core maintainers of this project aren't using Nix, so alternatively could just scrap the Nix stuff 🤷 . For Nix users, nix-prefetch-git https://github.com/justinwoo/easy-purescript-nix.git will get the latest rev and sha256, so this at least adds those instructions if it gets out of sync in the future. I wonder if it's something that could be automated in CI.

Also, those are some nice looking shadowed screenshots. Was wondering if that was a new GH feature, but guessing you just grabbed a bit of desktop too.

I'm on a Mac, that's just the default screenshot look when you capture a window. It is nice.

@JordanMartinez
Copy link
Owner

Yeah, nix is a great idea but something I just don't use right now. If we did support it, I would prefer to add a disclaimer of "use nix to build this project at your own risk; maintainers have not vetted what the nix code does" or something to that effect. If we don't do that, then dropping it entirely would be best.

@JordanMartinez
Copy link
Owner

I'm not sure I want to keep nix in the future, but I think this is safe to merge.

@JordanMartinez JordanMartinez merged commit e633104 into JordanMartinez:master Feb 9, 2021
@pete-murphy pete-murphy mentioned this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants