Implement eql and hash for Builder class #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Sorry I didn't see this until just now. If you could update the CHANGELOG |
ChrisBr
force-pushed
the
feature/implement_hash
branch
from
51a0f67 to
2880836
Compare
ChrisBr
force-pushed
the
feature/implement_hash
branch
from
2880836 to
dbadb81
Compare
|
Updated @gaorlov 👍 |
senid231
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would make sense to implement
hashandeql?on the builder.One usecase we have is to cache a response for a couple of minutes and therefore we needed to implement hash.