Fix including with blank relationships #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaorlov Hi again ) |
stokarenko
force-pushed
the
fix-including-with-blank-relationships
branch
from
248feaa to
a3544c3
Compare
|
hahaha! perfect. Can you update the change log and i'll push out Thanks! |
|
done! ) |
|
I see, fixing, 10 mins ) |
stokarenko
force-pushed
the
fix-including-with-blank-relationships
branch
from
a3544c3 to
2483f48
Compare
|
@stokarenko |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the minor breaking change introduced by 3048ea3#diff-cd00f457f4dd1dac9e58ef9c63390ca1R514:
Given: user = DocumentUser.includes('file').find(1).first
When: resource is coming with blank
relationships['file']json-api dataExpected: user.file to be nil
Actual: the exception raised