Skip to content

fix issue #352: relationships w/o included data #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2019
Merged

fix issue #352: relationships w/o included data #353

merged 2 commits into from
Jul 23, 2019

Conversation

dugsmith
Copy link
Contributor

No description provided.

@dugsmith
Copy link
Contributor Author

Hey @gaorlov, I think this will be a relatively quick one, if you agree with the issue #352 and my fix.

gaorlov
gaorlov requested changes Jul 21, 2019
View reviewed changes
Copy link
Collaborator

@gaorlov gaorlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you update the change log and info the version change please

@gaorlov
Copy link
Collaborator

gaorlov commented Jul 21, 2019

Thanks a ton for taking the time!

@dugsmith dugsmith force-pushed the fix_included_data branch from 6aa4adb to 3939323 Compare July 22, 2019 20:01
@dugsmith
Copy link
Contributor Author

@gaorlov: Thanks! I made the changes you requested.

gaorlov
gaorlov approved these changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@gaorlov gaorlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for the contribution! I'll merge and ship the next version tonight

@dugsmith
Copy link
Contributor Author

@gaorlov Great! Thanks for the quick turnaround! :-)

@gaorlov gaorlov merged commit e2784d9 into JsonApiClient:master Jul 23, 2019
@gaorlov
Copy link
Collaborator

gaorlov commented Jul 23, 2019

@dugsmith 1.14.1 is live. Thanks so much for the contribution!

@dugsmith
Copy link
Contributor Author

@gaorlov Excellent! Thank you! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaorlov gaorlov gaorlov approved these changes

@kujma10-zz kujma10-zz kujma10-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dugsmith @gaorlov @kujma10-zz