Skip to content

Add gemfile for Rails 6.0 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Jul 31, 2019

This pull request adds gemfile for Rails 6.0 to run CI against Rails 6.0.

  • The latest version of Rails 6.0 is Rails 6.0.0.rc2 as of today
  • Rails 6.0 requires Ruby 2.5.0 then excluded CI against Ruby 2.4 or lower

Refer Rails 6.0 required_ruby_version
https://github.com/rails/rails/blob/16f2cd88e3ee92de341ba30b102e9206be3c68a7/rails.gemspec#L12

* The latest version of Rails 6.0 is Rails 6.0.0.rc2
* Rails 6.0 requires Ruby 2.5.0 then excluded CI agains Ruby 2.4 or
lower

Refer Rails 6.0 required_ruby_version
https://github.com/rails/rails/blob/16f2cd88e3ee92de341ba30b102e9206be3c68a7/rails.gemspec#L12
Copy link
Collaborator

@gaorlov gaorlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time!

@gaorlov gaorlov merged commit daf5fbc into JsonApiClient:master Aug 27, 2019
@yahonda yahonda deleted the ci_against_rails60 branch August 27, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants