Skip to content

call super from inherited method so that it will execute parent classes' implementations #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2019
Merged

call super from inherited method so that it will execute parent classes' implementations #361

merged 2 commits into from
Oct 4, 2019

Conversation

mqchau
Copy link

@mqchau mqchau commented Sep 25, 2019

Fixes #360

@mqchau
Copy link
Author

mqchau commented Sep 25, 2019 •
edited
Loading

@lcpriest @gaorlov You two were involved in the PR #346 that introduced this method.
Please help me review this PR.

@gaorlov
Copy link
Collaborator

gaorlov commented Oct 2, 2019

This looks good. Thanks for the PR! Can you please update the unreleased section of the changefile?
Thanks!

@mqchau mqchau changed the title call from method so that it will execute parent classes' implementation call super from inherited method so that it will execute parent classes' implementations Oct 3, 2019
@mqchau
Copy link
Author

mqchau commented Oct 3, 2019

@gaorlov done

@gaorlov gaorlov merged commit 3c8f4d2 into JsonApiClient:master Oct 4, 2019
@gaorlov
Copy link
Collaborator

gaorlov commented Oct 4, 2019

@mqchau, 1.16.1 with your fix is live. Thanks so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaorlov gaorlov gaorlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of inherited method doesn't call super
2 participants
@mqchau @gaorlov