update TagBot #36
Merged
update TagBot #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: JuliaRegistries/TagBot@v1 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| ssh: ${{ secrets.DOCUMENTER_KEY }} |
There was a problem hiding this comment.
This is specifically needed when unit test CI is run on github action. This ssh key helps work around the limitation that "one github action cannot trigger another one". MappedArrays is still using travis so we don't need this.
Most importantly, I believe for this repo, DOCUMENTER_KEY key isn't set.
There was a problem hiding this comment.
You're right, but do you plan to move away from travis at some point? I had retained this as a future-proof command
There was a problem hiding this comment.
I believe we should but given that this package isn't actively developed, this is of low priority. I don't have write access to this repo so we should leave it to @timholy.
|
I added the key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to the suggested workflow to work around github disabling actions on inactive repos.