Skip to content

Changes to one() implementation seem to break Rotations.jl #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
c42f opened this issue Dec 19, 2019 · 1 comment
Closed

Changes to one() implementation seem to break Rotations.jl #700

c42f opened this issue Dec 19, 2019 · 1 comment
Labels
breaking-change bug release
Milestone
v0.12.2

Comments

@c42f
Copy link
Member

c42f commented Dec 19, 2019

It seems some recent changes on master have broken the Rotations tests (very likely #690).

This needs detangling before the next 0.12.2 release (Is Rotations depending on an implementation detail of StaticArrays... or did #690 somehow break the public API?)
@c42f c42f mentioned this issue Dec 19, 2019
Closed
@c42f c42f mentioned this issue Mar 24, 2020
Closed
This was referenced Apr 13, 2020
Merged
Open
@c42f c42f added this to the v0.12.2 milestone Apr 14, 2020
@c42f c42f mentioned this issue Apr 14, 2020
Closed
@c42f
Copy link
Member Author

c42f commented Apr 24, 2020

Fixed in #763

@c42f c42f closed this as completed Apr 24, 2020
c42f referenced this issue Apr 26, 2020
@c42f
Bump version to 0.12.2
71d3e35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change bug release
Projects
None yet
Milestone
v0.12.2
Development

No branches or pull requests
1 participant
@c42f