Fix accidential API breakage in one() #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that Rotations relies on one(M) calling the constructor of M, so transitioning to use of simliar_type broke Rotations. It's arguably a bug to call the constructor rather than calling similar_type, but let's avoid breaking compatibility for now. (It's a bug because some sets of matrices defined by a type cannot represent the multiplicative identity, for example the set of skew-symmetric matrices. StaticArrays should likely assume that generic operations like one() must devolve to a matrix type which can represent anything in GL(n,R). For example, SMatrix.)
|
Good point, Chris. Rotations are also an example where Should we patch Rotations.jl if that is where the misunderstanding is? |
Yes indeed! I left a too-long comment in the code with something to that effect :-) Rough plan was to revert this temporarily, fix |
This was referenced Apr 14, 2020
|
See companion issues: |
|
It should be uncontroversial that we need this for the next release, so I've merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix release-blocking bug #700 .
It turns out that Rotations.jl relies on
one(M)calling the constructor ofM, so transitioning to use ofsimliar_typein #690 brokeRotations.It's arguably a bug to call the constructor rather than calling
similar_type, but let's avoid breaking compatibility for now.I say it's arguably a bug because some sets of matrices defined by a type cannot represent the multiplicative identity, for example the set of skew-symmetric matrices. StaticArrays should likely assume that generic operations like
one()must devolve to a matrix type which can representanything in GL(n,R).