Skip to content

Make scalar multiplication type stable #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 26, 2021

Conversation

eschnett
Copy link
Contributor

Also provide a unary + operator.

Closes #899.

Also provide a unary + operator.
@mateuszbaran
Copy link
Collaborator

Thanks for a patch, could you also add appropriate @inferred tests for this case?

@eschnett
Copy link
Contributor Author

I see errors

Test Failed at /Users/eschnett/.julia/dev/StaticArrays/test/ambiguities.jl:19
  Expression: length(detect_ambiguities(Base, LinearAlgebra, StaticArrays)) <= allowable_ambiguities
   Evaluated: 61 <= 0
ERROR: LoadError: LoadError: There was an error during testing
in expression starting at /Users/eschnett/.julia/dev/StaticArrays/test/ambiguities.jl:13
in expression starting at /Users/eschnett/.julia/dev/StaticArrays/test/runtests.jl:38
ERROR: Package StaticArrays errored during testing

However, I already see them with the head of the master branch, it's not caused by my pull request.

@mateuszbaran
Copy link
Collaborator

These errors are a separate issue.

@mateuszbaran
Copy link
Collaborator

One last thing, could you bump version to 1.1.2?

@mateuszbaran mateuszbaran merged commit 9a9ddac into JuliaArrays:master Apr 26, 2021
@eschnett eschnett deleted the eschnett/mul branch February 14, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix multiplication is not type stable
2 participants