Fix reshaping of a mutable StaticArray #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My understanding is If this breaks dependent packages this is really a bug in those packages since they shouldn't have assumed it was making a |
|
Yes, should be totally fine to fix this bug. |
|
OK, I've changed it so that no reshape methods (except the one for |
thchr
pushed a commit
to thchr/StaticArrays.jl
that referenced
this pull request
Jul 8, 2021
* Fix reshaping of a mutable StaticArray * more reshape changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issue described in #907 . I've tried to make changes as limited as possible, so
reshape(::AbstractArray, ::Size)still makes a copy. I can change that but doing so is not essential to fixing the key problem, that isreshape(::StaticArray, ::SOneTo...)making a copy, which is fixed here.This looks like a change that may have some impact on downstream packages so I hope to get some feedback 🙂 .
cc @KristofferC @dlfivefifty @andyferris .