Update versions in ci.yml #970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyferris
approved these changes
Nov 3, 2021
c42f
reviewed
Nov 11, 2021
.github/workflows/ci.yml
Outdated
| with: | ||
| version: '1.4' | ||
| version: '1' |
There was a problem hiding this comment.
It may be better to specify a particular version here, for example 1.6.
The reason is that jldoctest blocks are very sensitive to formatting and the output of Base.show is not considered part of the stable interface for Base.
So doctests can break between Julia versions.
thchr
reviewed
Jan 6, 2022
|
Close this PR because #985 is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The document is generated with Julia 1.4.2, but this can be updated.