Skip to content

Allow 0x0 matrices for exp, inv, sqrt #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2022

Conversation

eschnett
Copy link
Contributor

No description provided.

@eschnett eschnett changed the title Allow 0x0 matrices for exp, sqrt Allow 0x0 matrices for exp, inv, sqrt Feb 10, 2022
@eschnett eschnett marked this pull request as ready for review February 10, 2022 01:52
@eschnett
Copy link
Contributor Author

CI reports indexing errors in SDiagonal. These errors appear unrelated.

Co-authored-by: Mateusz Baran <[email protected]>
eschnett and others added 2 commits February 12, 2022 13:20
Co-authored-by: Mateusz Baran <[email protected]>
Co-authored-by: Mateusz Baran <[email protected]>
@eschnett
Copy link
Contributor Author

The CI failure in Windows is a segfault in qr, very likely unrelated to my changes.

@mateuszbaran
Copy link
Collaborator

Yes, and it's only in Julia nightly so I wouldn't worry about that. I'm going to merge it tomorrow if no one raises any concerns (BTW, you can bump patch version of StaticArrays.jl so that a new version can be tagged).

@mateuszbaran mateuszbaran merged commit 1858207 into JuliaArrays:master Feb 14, 2022
@eschnett eschnett deleted the eschnett/sqrt0 branch February 14, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants