Small tweaks to reduce the need for inference #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's hard to understand how this wasn't an error.
This reduces the number of generators that need to be compiled, fixes a minor inference issue, and adds a couple of precompiles. All of very minor consequence, but not bad to have.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 89.08% 92.47% +3.39%
==========================================
Files 5 5
Lines 916 970 +54
==========================================
+ Hits 816 897 +81
+ Misses 100 73 -27
Continue to review full report at Codecov.
|
timholy
added a commit
to timholy/Revise.jl
that referenced
this pull request
Dec 20, 2020
Investigation via `SnoopCompile.@snoopi_deep` identified several opportunities to reduce latency: - JuliaLang/julia#38906 - JuliaDebug/JuliaInterpreter.jl#461 - JuliaDebug/LoweredCodeUtils.jl#58 Together with the changes here, the aggregate effect is to reduce the time for the first revision from 3.1s to about 1.5s. That's much more reasonable.
timholy
added a commit
to timholy/Revise.jl
that referenced
this pull request
Dec 21, 2020
Investigation via `SnoopCompile.@snoopi_deep` identified several opportunities to reduce latency: - JuliaLang/julia#38906 - JuliaDebug/JuliaInterpreter.jl#461 - JuliaDebug/LoweredCodeUtils.jl#58 Together with the changes here, the aggregate effect is to reduce the time for the first revision from 3.1s to about 1.5s. That's much more reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of generators that need to be compiled,
fixes a minor inference issue, and adds a couple of precompiles.
All of very minor consequence, but not bad to have.
However, the fix to the
Linksconstructor seems important andslightly bizarre that it worked previously.