Skip to content

function barrier reduces impact of type instability #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

baggepinnen
Copy link
Contributor

Looping over t caused lots of allocations. This PR introduces a function barrier that lessens the impact of this to almost negligible

Looping over `t` caused lots of allocations. This PR introduces a function barrier that lessens the impact of this to almost negligible
@codecov-commenter
Copy link

Codecov Report

Merging #196 (9c75bb6) into master (2e9dfed) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   80.64%   80.73%   +0.08%     
==========================================
  Files          15       15              
  Lines         863      867       +4     
==========================================
+ Hits          696      700       +4     
  Misses        167      167              
Impacted Files Coverage Δ
src/differentiation/compute_jacobian_ad.jl 90.00% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 16789e2 into JuliaDiff:master Aug 23, 2022
@baggepinnen baggepinnen deleted the patch-1 branch August 23, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants