Skip to content

VecJac also has inplace definitions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2023
Merged

VecJac also has inplace definitions #256

merged 1 commit into from
Aug 28, 2023

Conversation

avik-pal
Copy link
Contributor

@avik-pal avik-pal commented Aug 27, 2023

This seems to have broken SteadyStateAdjoint when using Iterative Linear Solvers

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (db2f2ae) 87.35% compared to head (deaef93) 87.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          21       21           
  Lines        1178     1178           
=======================================
  Hits         1029     1029           
  Misses        149      149           
Files Changed Coverage Δ
src/differentiation/vecjac_products.jl 93.75% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 27b8617 into JuliaDiff:master Aug 28, 2023
@avik-pal avik-pal deleted the ap/vecjac branch August 31, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants