Skip to content

Fix version bounds for broken test #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025

Conversation

christiangnrd
Copy link
Member

@christiangnrd christiangnrd commented Jun 6, 2025

Found while working on #592. This should be much quicker to merge on its own

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/testsuite/base.jl b/test/testsuite/base.jl
index 6bcfd5b..a6e6a53 100644
--- a/test/testsuite/base.jl
+++ b/test/testsuite/base.jl
@@ -399,11 +399,12 @@ end
         end
         @test(Array(b) == [1.0 0.0 0.0; 2.0 2.0 3.0],
               broken=(AT <: Array &&
-                        (v"1.11.0-DEV.727" <= VERSION < v"1.11.0-beta2" || # broken in JuliaLang/julia#51760 & reverted in beta2
-                          v"1.12.0-" <= VERSION < v"1.12.0-DEV.528"
-                        )
-                      )
-              )
+                        (
+                        v"1.11.0-DEV.727" <= VERSION < v"1.11.0-beta2" || # broken in JuliaLang/julia#51760 & reverted in beta2
+                            v"1.12.0-" <= VERSION < v"1.12.0-DEV.528"
+                    )
+                )
+            )
 
         a = AT(Float32[1.0 0.0 0.0; 2.0 2.0 3.0])
         b = reinterpret(reshape, ComplexF32, a)

@christiangnrd
Copy link
Member Author

This removes the one error I expected it to (in Array/base) and doesn't add any new errors so it's ready for review

@christiangnrd christiangnrd merged commit 505783e into JuliaGPU:master Jun 8, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants