Skip to content

Implement one for R<:Rotation to respect the algebra of SO(n) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
c42f opened this issue Apr 14, 2020 · 0 comments · Fixed by #121
Closed

Implement one for R<:Rotation to respect the algebra of SO(n) #114

c42f opened this issue Apr 14, 2020 · 0 comments · Fixed by #121
Milestone

Comments

@c42f
Copy link
Member

c42f commented Apr 14, 2020

As described at JuliaArrays/StaticArrays.jl#763, Rotations relies on a particular buggy definition in StaticArrays for zero and one where the constructor of the static matrix type is called.

We should implement one(::Type{R<:Rotation}) here so we don't rely on that bug and so we can return something which isa R.

For zero we currently we have the following oddity (should not return a RotMatrix!). This is a bug which should be fixed in StaticArrays:

julia> zero(RotMatrix{2})
2×2 RotMatrix{2,Float64,4} with indices SOneTo(2)×SOneTo(2):
 0.0  0.0
 0.0  0.0
@c42f c42f changed the title Implement one for R<:Rotation to respect the algebra of SO(N) Implement one for R<:Rotation to respect the algebra of SO(n) Apr 14, 2020
@c42f c42f added this to the v1.0 milestone Apr 14, 2020
@c42f c42f mentioned this issue May 3, 2020
@c42f c42f closed this as completed in #121 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant