Specialize rotations by π #163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 85.40% 85.41% +0.01%
==========================================
Files 12 12
Lines 1261 1262 +1
==========================================
+ Hits 1077 1078 +1
Misses 184 184
Continue to review full report at Codecov.
|
andyferris
approved these changes
Oct 10, 2021
|
Good idea. It seems that it may even be better to move this to a lower level of the hierarchy, see JuliaLang/julia#42595. |
|
With JuliaLang/julia#42595 merged, I think we can safely close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since π is quite special when it comes to rotations,
and Julia goes to lengths to preserve it exactly,
we might as well exploit that here.