Skip to content

Generalize non-parametric type handling #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Generalize non-parametric type handling #149

merged 1 commit into from
Apr 10, 2021

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Apr 8, 2021

This should not be a breaking change. (Oh, I thought I had created this branch on my fork. Sorry.)

Closes #146.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #149 (32aa8aa) into master (85b8759) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   92.48%   92.99%   +0.50%     
==========================================
  Files           2        2              
  Lines         213      214       +1     
==========================================
+ Hits          197      199       +2     
+ Misses         16       15       -1     
Impacted Files Coverage Δ
src/ColorVectorSpace.jl 98.51% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b8759...32aa8aa. Read the comment docs.

@kimikage kimikage closed this Apr 8, 2021
@kimikage kimikage deleted the nonparametric branch April 8, 2021 09:31
@kimikage kimikage restored the nonparametric branch April 8, 2021 09:32
@kimikage kimikage reopened this Apr 8, 2021
@kimikage
Copy link
Collaborator Author

This has almost no negative effect on the existing codes, so I'll merge this.
However, I do not plan to release it immediately. Probably more work related to issue #155 will follow.

@kimikage kimikage merged commit 7d02097 into master Apr 10, 2021
@kimikage kimikage deleted the nonparametric branch April 10, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalization of non-parametric type handling
1 participant