Skip to content

Add error hints for unsuported operations #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Apr 26, 2021

This also adds the note for abs/abs2 into README.md.

If necessary, I will write the tests for error hints.

@kimikage kimikage marked this pull request as draft April 26, 2021 11:59
This also adds the note for `abs`/`abs2` into README.md.
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #164 (3a885b0) into master (81c9ada) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   92.82%   92.95%   +0.13%     
==========================================
  Files           2        2              
  Lines         209      213       +4     
==========================================
+ Hits          194      198       +4     
  Misses         15       15              
Impacted Files Coverage Δ
src/ColorVectorSpace.jl 98.50% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c9ada...3a885b0. Read the comment docs.

@johnnychen94
Copy link
Member

If necessary, I will write the tests for error hints.

It's your call, I'd be satisfied with this already!

@kimikage kimikage marked this pull request as ready for review April 26, 2021 23:49
@kimikage kimikage closed this Apr 26, 2021
@kimikage kimikage reopened this Apr 26, 2021
@kimikage
Copy link
Collaborator Author

To merge #158 and release v0.9.4, I will merge this first.
The documentation and error messages can be modified at any time.

@kimikage kimikage merged commit 4e39011 into JuliaGraphics:master Apr 27, 2021
@kimikage kimikage deleted the hint_for_mul branch April 27, 2021 00:17
@kimikage kimikage mentioned this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants