Skip to content

Store run-time property lists in scalar arrays #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2015
Merged

Store run-time property lists in scalar arrays #250

merged 1 commit into from
Aug 9, 2015

Conversation

petercolberg
Copy link
Contributor

This stores the HDF5 property lists that are created during module initialization using a scalar array for each property, which avoids the use of hard-coded indices.

@petercolberg
Copy link
Contributor Author

Julia nightly appears to fail on import Blosc:

Julia Version 0.4.0-dev+6531
Commit e6180f0 (2015-08-07 23:10 UTC)
ERROR: LoadError: LoadError: LoadError: LoadError: __precompile__(true) but require failed to create a precompiled cache file
 in require at ./loading.jl:211
 in include at ./boot.jl:254
 in include_from_node1 at ./loading.jl:263
 in include at ./boot.jl:254
 in include_from_node1 at ./loading.jl:263
 in include at ./boot.jl:254
 in include_from_node1 at ./loading.jl:263
 in require at ./loading.jl:202
 in include at ./boot.jl:254
 in include_from_node1 at ./loading.jl:263
 in process_options at ./client.jl:308
 in _start at ./client.jl:411
while loading /home/travis/.julia/v0.4/HDF5/src/blosc_filter.jl, in expression starting on line 1
while loading /home/travis/.julia/v0.4/HDF5/src/plain.jl, in expression starting on line 509
while loading /home/travis/.julia/v0.4/HDF5/src/HDF5.jl, in expression starting on line 1
while loading /home/travis/.julia/v0.4/HDF5/test/runtests.jl, in expression starting on line 1

@timholy
Copy link
Member

timholy commented Aug 8, 2015

This looks like a nice change, 👍. Once we require julia 0.4, we'll probably want to switch to a Ref.

Re the Blosc/precompilation failure: CC @stevengj. Blosc works fine for me locally. A couple of lines above that Travis error are interesting, too:

INFO: Recompiling stale cache file /home/travis/.julia/lib/v0.4/Blosc.ji for module Blosc.
WARNING: Module Compat uuid did not match cache file
ERROR: LoadError: LoadError: LoadError: LoadError: __precompile__(true) but require failed to create a precompiled cache file
...

@stevengj
Copy link
Member

stevengj commented Aug 8, 2015

@petercolberg, that is JuliaLang/julia#12508. It will go away once a new Compat is tagged, but for now you can just quit Julia and try again and it will work the second time.

@timholy
Copy link
Member

timholy commented Aug 9, 2015

I just tagged a new version of Compat (JuliaLang/METADATA.jl#3042), since all HDF5/JLD PRs are failing Travis tests.

timholy added a commit that referenced this pull request Aug 9, 2015
Store run-time property lists in scalar arrays
@timholy timholy merged commit 887c930 into JuliaIO:master Aug 9, 2015
@timholy
Copy link
Member

timholy commented Aug 9, 2015

Thanks, @petercolberg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants