Skip to content

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Aug 12, 2024

Fixes #223 Fixes #234
Removes:

function test_roundtrip_read end
function test_roundtrip_write end
function test_roundtrip_transcode end
function test_roundtrip_lines end
function test_roundtrip_seekstart end
function test_roundtrip_fileio end
function test_chunked_read end
function test_chunked_write end

These functions have been moved into lib/TestsForCodecPackages in #235

I decided not to keep the functions as noops that always pass, because:

  1. I have already updated all usage of the functions I could find on JuliaHub. Ref: use TestsForCodecPackages.jl CodecZlib.jl#84 use TestsForCodecPackages.jl CodecInflate64.jl#2 use TestsForCodecPackages CodecXz.jl#29 use TestsForCodecPackages.jl CodecBase.jl#17 use TestsForCodecPackages.jl CodecZstd.jl#61 use TestsForCodecPackages.jl CodecBzip2.jl#34 use TestsForCodecPackages.jl CodecLz4.jl#58
  2. These functions are not exported or documented, so they are not part of the API of this package.
  3. It is better for a no longer working testing function to fail loudly.

@nhz2 nhz2 marked this pull request as ready for review August 12, 2024 00:50
@nhz2 nhz2 requested a review from mkitti August 12, 2024 00:50
@nhz2 nhz2 merged commit 130a1ff into master Aug 12, 2024
@nhz2 nhz2 deleted the nz/remove-test-ext branch August 12, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants