Skip to content

Typo in extreme_filter documentation #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Typo in extreme_filter documentation #131

wants to merge 1 commit into from

Conversation

camilodlt
Copy link

Removed an extra "the"

@camilodlt
Copy link
Author

A doctest failed. Maybe something about WARNING: llvmcall with integer pointers is deprecated.

@bjarthur
Copy link
Contributor

@ThomasRetornaz ditto

@ThomasRetornaz
Copy link
Collaborator

Sorry for that
Ok for me

@ThomasRetornaz
Copy link
Collaborator

A doctest failed. Maybe something about WARNING: llvmcall with integer pointers is deprecated.

WARNING: llvmcall with integer pointers is deprecated.
│ Use actual pointers instead, replacing i32 or i64 with i8* or ptr
│ in _unsafe_shift_arith!(Union{typeof(Base.max), typeof(Base.min)}, AbstractArray{T, 1} where T, AbstractArray{T, 1} where T, AbstractArray{T, 1} where T, AbstractArray{T, 1} where T) at /home/runner/work/ImageMorphology.jl/ImageMorphology.jl/src/extreme_filter.jl

I will have a look

@ThomasRetornaz
Copy link
Collaborator

A doctest failed. Maybe something about WARNING: llvmcall with integer pointers is deprecated.

WARNING: llvmcall with integer pointers is deprecated. │ Use actual pointers instead, replacing i32 or i64 with i8* or ptr │ in _unsafe_shift_arith!(Union{typeof(Base.max), typeof(Base.min)}, AbstractArray{T, 1} where T, AbstractArray{T, 1} where T, AbstractArray{T, 1} where T, AbstractArray{T, 1} where T) at /home/runner/work/ImageMorphology.jl/ImageMorphology.jl/src/extreme_filter.jl

I will have a look

The warning seems coming from LoopVectorization, may a update of this depency solve this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilodlt @bjarthur @ThomasRetornaz