Skip to content

Use of abs in the pivoting branch of the generic lufact. #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mschauer opened this issue Jan 29, 2020 · 3 comments
Open

Use of abs in the pivoting branch of the generic lufact. #693

mschauer opened this issue Jan 29, 2020 · 3 comments
Labels
needs decision A decision on this change is needed speculative Whether the change will be implemented is speculative

Comments

@mschauer
Copy link
Contributor

The use of abs in the pivoting part broke some code of mine which was using the generic lu-fact on a matrix with elements of type SArray{Tuple{2,2},Float64,2,4}. This became visible with the change JuliaLang/julia#32989 making pivoting the default. Would norm be an option there?
@andreasnoack andreasnoack added needs decision A decision on this change is needed speculative Whether the change will be implemented is speculative labels Jan 29, 2020
@andreasnoack
Copy link
Member

Would norm be an option there?

I'd think so.

@mschauer mschauer mentioned this issue Jan 29, 2020
Merged
@andreasnoack
Copy link
Member

Closed by JuliaLang/julia#34575

@andreasnoack andreasnoack mentioned this issue May 30, 2020
Closed
@mschauer
Copy link
Contributor Author

This should be open again, as JuliaLang/julia#34575 wasn't the solution.

@andreasnoack andreasnoack reopened this Oct 22, 2020
@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs decision A decision on this change is needed speculative Whether the change will be implemented is speculative
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreasnoack @mschauer