Skip to content

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 14, 2025

The test failure in https://buildkite.com/julialang/linearalgebra-dot-jl/builds/330#01954c88-5de5-42fb-a0b4-e10f487d934e is because the matrix is not positive-definite. Since we construct the matrix by ourselves, we may ensure that the eigenvalues are all positive by defining it as Q*D*Q' for an orthogonal Q A'A + I. This way we avoid such floating-point issues.

@jishnub jishnub added the test This change adds or pertains to unit tests label Mar 14, 2025
@ViralBShah
Copy link
Member

@KristofferC - Seeing this in the i686 CI. Is this a problem?

- PackageCompiler: compiling nonincremental system image
  | ERROR: IOError: could not spawn `/shells/bash -c '(pwd) && true'`: no such file or directory (ENOENT)
  | Running parallel tests with:
  | getpid() = 450
  | nworkers() = 16
  | nthreads(:interactive) = 1
  | nthreads(:default) = 1
  | Sys.CPU_THREADS = 16
  | Sys.total_memory() = 503.719 GiB
  | Sys.free_memory() = 470.665 GiB
  |  

<br class="Apple-interchange-newline">

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (4c9e125) to head (545d307).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1238   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files          34       34           
  Lines       15475    15475           
=======================================
  Hits        14231    14231           
  Misses       1244     1244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah merged commit 38273fd into master Mar 15, 2025
4 checks passed
@ViralBShah ViralBShah deleted the jishnub/lapackposv branch March 15, 2025 21:55
@ViralBShah ViralBShah added the backport 1.12 Change should be backported to release-1.12 label Mar 19, 2025
@jishnub jishnub mentioned this pull request May 12, 2025
27 tasks
jishnub added a commit that referenced this pull request May 26, 2025
Backported PRs:
- [x] #1209 <!-- Remove `LinearAlgebra` qualifications in `cholesky.jl`
-->
- [x] #1230 <!-- Avoid materializing `diag` in `Diagonal` `kron` -->
- [x] #1240 <!-- Reduce `stable_muladdmul` branches in `generic
matvecmul!` -->
- [x] #1247 <!-- fix dispatch to herk -->
- [x] #1255 <!-- use smaller matrix size in `peakflops` on 32-bit -->
- [x] #1310 <!-- Only `@noinline` error path in `matmul_size_check` -->
- [x] #1267 <!-- Refine column ranges in `_isbanded_impl` -->
- [x] #1320 <!-- Copy matrices in `triu`/`tril` if no zero exists for
the `eltype` -->
- [x] #1324 <!-- Fix empty `Tridiagonal` broadcast -->
- [x] #1327 <!-- `iszero` check in hessenberg setindex -->
- [x] #1326 <!-- Fix multiplication with empty `HessenbergQ` -->
- [x] #1332 <!-- Unwrap triangular matrices in broadcast -->
- [x] #1337 <!-- Change `1:size` to `axes` in bidiag mul -->
- [x] #1342 <!-- `Char` uplo in `Bidiagonal` constructor -->
- [x] #1344 <!-- Update the docstring of ldiv! -->
- [x] #1335 <!-- Test: prune old LA based on ENV variable -->
- [x] #1346 <!-- Fix scaling unit triangular matrices -->
- [x] #1355 <!-- Add compat notice for `diagview` -->
- [x] #1349 <!-- Prune `LinearAlgebra` module in ambiguity test -->

Contains multiple commits, manual intervention needed:
- [x] #1238 <!-- Ensure positive-definite matrix in lapack posv test -->
- [x] #1298 <!-- Add `diagm` example -->
- [x] #1312 <!-- WIP: Try use method deletion instead of custom sysimage
-->
- [x] #1333 <!-- Make `fillstored!` public -->
- [x] #1331 <!-- Document SingularException throw for
inv(::AbstractMatrix) -->
- [x] #1350 <!-- Fix copy for partly initialized unit triangular -->

Non-merged PRs with backport label:
- [x] #1352 <!-- log for dense diagonal matrix with negative elements
-->
- [ ] #1305 <!-- Bounds-checking in triangular indexing branches -->

---------

Co-authored-by: Mateus Araújo <[email protected]>
Co-authored-by: Jeff Bezanson <[email protected]>
Co-authored-by: Steven G. Johnson <[email protected]>
Co-authored-by: WalterMadelim <[email protected]>
Co-authored-by: Kristoffer Carlsson <[email protected]>
Co-authored-by: Daniel Karrasch <[email protected]>
Co-authored-by: Michael Abbott <[email protected]>
@jishnub jishnub removed the backport 1.12 Change should be backported to release-1.12 label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants