setindex! with BandIndex
#1259
Merged
setindex! with BandIndex
#1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
+ Coverage 92.01% 92.03% +0.02%
==========================================
Files 34 34
Lines 15500 15540 +40
==========================================
+ Hits 14262 14302 +40
Misses 1238 1238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jishnub
force-pushed
the
jishnub/bandindex_setindex
branch
from
dbd4dff to
d0d8279
Compare
jishnub
force-pushed
the
jishnub/bandindex_setindex
branch
from
d0d8279 to
258102f
Compare
dkarrasch
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant-propagation of the band index would allow eliminating the branches in
setindex!for structured matrices. These parallel the similargetindexdefinitions that already exist.