Change default symmetriceigen algorithm back to RobustRepresentations #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
- Coverage 93.76% 93.74% -0.02%
==========================================
Files 34 34
Lines 15724 15724
==========================================
- Hits 14743 14741 -2
- Misses 981 983 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ViralBShah
approved these changes
May 28, 2025
jishnub
pushed a commit
that referenced
this pull request
Jun 5, 2025
…#1363) See #1313 A brief summary: RobustRepresentations (`LAPACK.syevr!`) was the only algorithm implemented until Julia v1.11. Then, JuliaLang/julia#49355 implemented interface to other algorithms, and changed the default to DivideAndConquer (`LAPACK.syevd!`) based on its better numerical accuracy and performance. But, it turned out that in some LAPACK implementation, the DivideAndConquer fails more frequently than RobustRepresentations (#1313). Based on the discussion in #1313 , this PR reverts the default algorithm to RobustRepresentations. Once the problem with the RobustRepresentations in the problematic LAPACK implementation has been sorted out, the default could be changed to DivideAndConquer. (cherry picked from commit b6ad8f9)
jishnub
added a commit
that referenced
this pull request
Jun 13, 2025
Backported PRs: - [x] #1364 <!-- clarify eigen docstring --> - [x] #1363 <!-- Change default symmetriceigen algorithm back to RobustRepresentations --> Non-merged PRs with backport label: - [ ] #1365 <!-- Add docstring to the `rank(::QRPivoted)` method --> - [ ] #1305 <!-- Bounds-checking in triangular indexing branches -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1313
A brief summary: RobustRepresentations (
LAPACK.syevr!) was the only algorithm implemented until Julia v1.11. Then, JuliaLang/julia#49355 implemented interface to other algorithms, and changed the default to DivideAndConquer (LAPACK.syevd!) based on its better numerical accuracy and performance. But, it turned out that in some LAPACK implementation, the DivideAndConquer fails more frequently than RobustRepresentations (#1313). Based on the discussion in #1313 , this PR reverts the default algorithm to RobustRepresentations.Once the problem with the RobustRepresentations in the problematic LAPACK implementation has been sorted out, the default could be changed to DivideAndConquer.