Skip to content

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 16, 2025

We may forward the operation to the parent, which would usually ensure that the loops are cache-friendly.

@dkarrasch
Copy link
Member

Any performance numbers?

@jishnub
Copy link
Member Author

jishnub commented Jun 16, 2025

julia> @btime triu!($A') setup=(A=rand(1000,1000));
  571.064 μs (0 allocations: 0 bytes) # nightly
  122.155 μs (0 allocations: 0 bytes) # this PR

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.82%. Comparing base (3537c3a) to head (0149ac4).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1385   +/-   ##
=======================================
  Coverage   93.81%   93.82%           
=======================================
  Files          34       34           
  Lines       15718    15720    +2     
=======================================
+ Hits        14746    14749    +3     
+ Misses        972      971    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit 045ee5c into master Jun 18, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/adjtrans_triul branch June 18, 2025 08:13
@ViralBShah ViralBShah added the backport 1.12 Change should be backported to release-1.12 label Aug 13, 2025
dkarrasch pushed a commit that referenced this pull request Aug 18, 2025
We may forward the operation to the parent, which would usually ensure
that the loops are cache-friendly.
ViralBShah added a commit that referenced this pull request Aug 19, 2025
@dkarrasch dkarrasch removed the backport 1.12 Change should be backported to release-1.12 label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants