Skip to content

Enable OpenSSL certificates #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Conversation

eschnett
Copy link
Contributor

I'm working on replacing MbedTLS by OpenSSL in Julia. See JuliaLang/julia#56708. This allows (requires?) enabling OpenSSL certificates.

@eschnett eschnett marked this pull request as ready for review November 29, 2024 02:02
@eschnett eschnett marked this pull request as draft November 29, 2024 02:06
@eschnett eschnett marked this pull request as ready for review November 29, 2024 21:22
@fxcoudert
Copy link

ping @StefanKarpinski on this? This is required for the julia PR at JuliaLang/julia#56708 given that MbedTLS is reaching end-of-support.

@giordano
Copy link
Member

giordano commented Jan 4, 2025

I'm not familiar with the codebase, but the suggested changes look reasonable to me and we've already got an approval. If anyone has further improvements they can be made in a follow up PR, but this is important to move JuliaLang/julia#56708 forward, so I'm going to merge it.

@giordano giordano merged commit c090626 into JuliaLang:master Jan 4, 2025
15 checks passed
@StefanKarpinski
Copy link
Member

Sorry for the slow reply. This seems reasonable if we can handle OpenSSL certificates now. The issue before was that we couldn't and Downloads would choke on cert files that contained no regular certs. The only potential improvements here is that we could detect whether we're using MbedTLS or OpenSSL and automatically skip if needed, but this is fine unless there are problems. I don't really think it makes much sense for the NetworkOptions version to be decoupled from the Julia version anyway. It's theoretically possible, but just not very useful imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants