Julia embedding example cannot be compiled in 1.5.2

[uformia]

On the 1.5.2 branch (or 1.5.1), the file src/atomics.h is missing a template keyword for jl_atomic_store_release , around line 269, making the file uncompilable (in VS2017). See

julia/src/atomics.h

Line 269 in 539f3ce

static inline void jl_atomic_store_relaxed(volatile T *obj, T2 val)

.

This is compiling the code at https://docs.julialang.org/en/v1/manual/embedding/#High-Level-Embedding-on-Windows-with-Visual-Studio .

This change is made in commit 2b510b4 on master, which appears to be working on a different feature, but that commit is not in 1.5.2 .

[JeffBezanson]

Thanks. Would you be willing to open a PR against release-1.5 adding that line?

[rpep]

Think this is a duplicate of #36481, but there are broader problems that make this not work too.

[hheld]

It still can't be compiled with Julia version 1.6.1. It shows a different error though: Now it doesn't know what jl_atomic_load_relaxed is.

Is there a solution for this?

[ViralBShah]

MSVC Should be working with #44976. Please reopen if still an issue.