- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Closed
Labels
bugIndicates an unexpected problem or unintended behaviorIndicates an unexpected problem or unintended behaviorregressionRegression in behavior compared to a previous versionRegression in behavior compared to a previous version
Description
Especially, I found :jl_coverage_visit_line
couldn't be loaded:
julia> let
file = @__FILE__
line = @__LINE__
ccall(:jl_coverage_visit_line, Cvoid, (Cstring, Csize_t, Cint), file, sizeof(file), line)
end
ERROR: could not load symbol "jl_coverage_visit_line":
dlsym(RTLD_DEFAULT, jl_coverage_visit_line): symbol not found
Stacktrace:
[1] top-level scope
@ ./REPL[1]:4
, which is defined at:
Lines 1861 to 1869 in 72ec349
extern "C" JL_DLLEXPORT void jl_coverage_visit_line(const char* filename_, size_t len_filename, int line) | |
{ | |
StringRef filename = StringRef(filename_, len_filename); | |
if (imaging_mode || filename == "" || filename == "none" || filename == "no file" || filename == "<missing>" || line < 0) | |
return; | |
std::vector<logdata_block*> &vec = coverageData[filename]; | |
uint64_t *ptr = allocLine(vec, line); | |
(*ptr)++; | |
} |
Bisected that #41936 seems to have caused this issue.
Metadata
Metadata
Assignees
Labels
bugIndicates an unexpected problem or unintended behaviorIndicates an unexpected problem or unintended behaviorregressionRegression in behavior compared to a previous versionRegression in behavior compared to a previous version
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
Core.Compiler
JuliaDebug/Cthulhu.jl#239JeffBezanson commentedon Oct 15, 2021
It might make sense to require explicitly requesting this from
libjulia-codegen
.vtjnash commentedon Oct 15, 2021
There's no particular reason that the interpreter should have to depend on having access to the compiler. Might need to move this to the runtime though.
JeffBezanson commentedon Oct 15, 2021
Yeah I agree, it makes sense to keep the coverage and malloc data in the runtime.
simeonschaub commentedon Oct 24, 2021
Is there a solution in sight for this? JuliaInterpreter now uses
jl_coverage_visit_line
, so this is quite breaking.JeffBezanson commentedon Oct 25, 2021
Yes I think this is not hard to fix.
fix #42659, move `jl_coverage_visit_line` to runtime library
jl_coverage_visit_line
to runtime library #42810fix #42659, move `jl_coverage_visit_line` to runtime library
fix #42659, move `jl_coverage_visit_line` to runtime library (#42810)
Squashed commit of the following:
2 remaining items