add trunc methods to BigInt, fixes #13367 #13376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be safely backported to 0.4, but given the late RC process, could probably wait until 0.4.1. |
simonbyrne
force-pushed
the
sb/bigint-trunc
branch
from
07d4747 to
b31925c
Compare
carlobaldassi
added a commit
that referenced
this pull request
Oct 1, 2015
add trunc methods to BigInt, fixes #13367
|
Thanks! |
|
@simonbyrne this causes method ambiguity warnings during bootstrap. |
|
Blegh, Is there any way we can get ambiguity warnings to fail tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13367.
round,ceilandfloorshould also work by fallbacks.