Prefer the parent module when serializing functions (fixes #13452)

[timholy]

I've verified that this works on 0.4.0-rc4, so @JuliaBackports.

[tkelman]

where does this rank in criticality? must do for final, or could wait for next point release?

[timholy]

I'm fine if we wait for point release---people like me can fix locally, there hasn't been a barnstorming of complaints about this, and I'm as excited as anyone to get 0.4 out.

FYI, those lines were last touched in 74b0488 and 015401d. CC @JeffBezanson.

[timholy]

If I wanted to get this into the release-0.4 queue, what's the proper procedure? Submit a cherry-pick PR against release-0.4, or are you staging these on some other branch?

[tkelman]

The label is the right procedure. I haven't started staging things for 0.4.1 yet, I consider #13550 release blocking. I will do a staging branch where I run PkgEval on code changes before merging them to release-0.4.

[timholy]

Your care in managing these releases is greatly appreciated.

[tkelman]

It's been working out pretty well so far 😀

Though I'm a little ashamed I let #13550 slip through without noticing beforehand, but the download numbers for 32 bit linux are the lowest of any of the platforms we regularly build binaries for so at least it isn't hitting too many users.

[timholy]

It's been working out pretty well so far 😀

I'd rate that as an understatement; perhaps it's just that the most vocal people were already running 0.4, but the relative lack of "this broke my code!" reports is quite amazing.