-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
hvcat doc example fixed #13566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hvcat doc example fixed #13566
Conversation
hvcat doc example was not working I changed it to one that does.
Note that the docstrings in the file you edited are auto-generated. The same change would also need to be made at the source for the docstring, Line 3795 in 6aa15b8
|
Probably the example would be clearer with a 2x3 matrix, as was originally (presumably) intended: julia> a, b, c, d, e, f = 1, 2, 3, 4, 5, 6
(1,2,3,4,5,6)
julia> [a b c; d e f]
2x3 Array{Int64,2}:
1 2 3
4 5 6 This can then be a doctest. |
Removed test for a non-working example and added clearer doctest example instead.
I fixed that now with a couple of clear doctest examples in my last commit. |
2x3 Array{Int64,2}: | ||
1 2 3 | ||
4 5 6 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the trailing whitespace from here and 3810, and if you've got a local source build it would also be handy if you could run make && usr/bin/julia doc/genstdlib.jl
on this branch to propagate these changes into the RST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed your instructions. The latest commit should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
hvcat doc example was not working
I changed it to one that does.